Fix surf --version to read version from package.json#33
Open
davidguttman wants to merge 1 commit intonicobailon:mainfrom
Open
Fix surf --version to read version from package.json#33davidguttman wants to merge 1 commit intonicobailon:mainfrom
davidguttman wants to merge 1 commit intonicobailon:mainfrom
Conversation
davidguttman
force-pushed
the
fix/version-from-package-json
branch
7 times, most recently
from
197a1f1 to
b00edf1
Compare
davidguttman
force-pushed
the
fix/version-from-package-json
branch
from
b00edf1 to
eb4e291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hardcoded VERSION (2.0.0) in native/cli.cjs with a runtime read of ../package.json so
surf --versionreflects the current package version.Tests: native/tests/cli-tests.sh